Re: [PATCH] regulator: core: use regulator name for sysfs

From: Mark Brown
Date: Thu Feb 21 2013 - 14:43:12 EST

On Thu, Feb 21, 2013 at 12:24:04PM -0700, Stephen Warren wrote:
> On 02/21/2013 12:53 AM, Shawn Joo wrote:

> > regulator is named by numbering on sysfs, e.g. regulator.0, regulator.1
> > it confuses to find desired regulator before counting the order.
> > add option for regulator name by use_name_onsysfs.
> > if it is true and name is not NULL, desc's name will be the name.
> > e.g. if name in desc is "LDO0", then regulator.LDO0 on sysfs.
> > otherwise it follows origin.

> Does it make sense to make this change always, rather than based on some
> new flag in regulator_desc?

It's certainly insane to change this based on the driver and given that
sysfs is supposed to be an ABI it's questionable if we should do it at
all. We certainly can't use the descriptor name as that's very likely
to clash if you have more than one PMIC. Taking a glance through sysfs
on my system what we're doing at the minute is pretty idiomatic, sysfs
isn't really intended for humans but rather for machines to prettify.

> Another place a similar change might be useful is debugfs.

debugfs already uses more human readable names, it uses the supply name
(which is what we should be using if we were going to do anything as
it really ought to be unique already).

Attachment: signature.asc
Description: Digital signature