Re: [PATCH] nohz: Make tick_nohz_irq_exit() irq safe
From: Linus Torvalds
Date: Thu Feb 21 2013 - 12:54:00 EST
On Wed, Feb 20, 2013 at 1:00 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> void irq_exit(void)
> +#ifndef __ARCH_IRQ_EXIT_IRQS_DISABLED
> + unsigned long flags;
> + local_irq_save(flags);
> + BUG_ON(!irqs_disabled();
Guys, STOP DOING THIS!
Adding BUG_ON()'s just makes things much much much worse. There is
*never* a reason to add a BUG_ON(). And doing it in an interrupt path
is totally unacceptable. BUG_ON() makes it almost impossible to debug
something, because you just killed the machine. So using BUG_ON() for
"please notice this" is stupid as hell, because the most common end
result is: "Oh, the machine just hung with no messages".
Make it WARN_ON_ONCE() if you absolutely have to let people know, but
for something like this, why would you do even that?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/