Re: [PATCH] fs: Preserve error code in get_empty_filp()
From: Theodore Ts'o
Date: Thu Feb 21 2013 - 11:36:15 EST
> > A little bit of context for this change. We at Google work on a test
> > framework that shows how kernel behaves under memory pressure. In the
> > codepath that I am fixing the syscalls return ENFILE error, but in
> > fact the correct error would be ENOMEM. get_empty_filp() should
> > preserve the original error and not to replace all errors with ENFILE.
> The trouble is, you are introducing previously impossible return values
> for pipe(2). The rest of it is probably OK (even though I'd prefer to
> split get_empty_filp() part into a separate commit), but this one has
> potential for breaking previously correct userland code. OTOH, FreeBSD has
> done that a while ago and they apparently had been able to cope with the
Sure, but Posix/SUSv3 has always said that system calls can return
error values that aren't listed in the standard (or the man page).
Given that most applications check for an error, and then use the
errno to log an error which a human can interpret, it would seem to me
to be better to return ENOMEM rather than to return the clearly wrong
ENFILE; after all, we could potentially have only a handful of file
descriptors open at the time when pipe(2) fails due to lack of memory,
and the error code:
ENFILE The system limit on the total number of open files has
is clearly wrong.
Are you aware of any applications that would blow up if pipe(2)
returned any possible error other than ENFILE?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/