Re: [PATCH 09/16] ia64 idle: delete pm_idle

From: Lars-Peter Clausen
Date: Thu Feb 21 2013 - 05:19:39 EST


On 02/10/2013 06:58 AM, Len Brown wrote:
> From: Len Brown <len.brown@xxxxxxxxx>
>
> pm_idle() on ia64 was a synonym for default_idle().
> So simply invoke default_idle() directly.
>
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Cc: linux-ia64@xxxxxxxxxxxxxxx
> ---
> arch/ia64/kernel/process.c | 3 ---
> arch/ia64/kernel/setup.c | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c
> index 31360cb..e34f565 100644
> --- a/arch/ia64/kernel/process.c
> +++ b/arch/ia64/kernel/process.c
> @@ -57,8 +57,6 @@ void (*ia64_mark_idle)(int);
>
> unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE;
> EXPORT_SYMBOL(boot_option_idle_override);
> -void (*pm_idle) (void);
> -EXPORT_SYMBOL(pm_idle);
> void (*pm_power_off) (void);
> EXPORT_SYMBOL(pm_power_off);
>
> @@ -301,7 +299,6 @@ cpu_idle (void)
> if (mark_idle)
> (*mark_idle)(1);
>
> - idle = pm_idle;
> if (!idle)

Hm, if I'm not mistaken idle will uninitialized at this point, so this could
quite likely lead to a crash.

> idle = default_idle;
> (*idle)();
> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
> index aaefd9b..2029cc0 100644
> --- a/arch/ia64/kernel/setup.c
> +++ b/arch/ia64/kernel/setup.c
> @@ -1051,7 +1051,6 @@ cpu_init (void)
> max_num_phys_stacked = num_phys_stacked;
> }
> platform_cpu_init();
> - pm_idle = default_idle;
> }
>
> void __init

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/