Re: [PATCH] spi: tegra114: add spi driver

From: Mark Brown
Date: Wed Feb 20 2013 - 12:31:19 EST

On Wed, Feb 20, 2013 at 10:25:13AM -0700, Stephen Warren wrote:

> But, please do think this approach through fully. The DT binding needs
> to define which clock-names the driver requires to be present, and any
> optional clock names. DT bindings are supposed to be immutable, or
> perhaps extendible in a completely backwards-compatible fashion. This
> implies that you need to have thought through the entire list of clocks
> that the driver might want in the DT clock-names property when you first
> write the DT binding documentation...

Since we can extend the list of clocks it doesn't seem like there's much
issue here, especially if some of them are optional?

Though in general it seems like this sort of mux really should be in the
clock stuff anyway.

Attachment: signature.asc
Description: Digital signature