Re: [PATCH 02/35] mfd: ab8500-gpadc: Allow tvout regulator to bemissing

From: Lee Jones
Date: Wed Feb 20 2013 - 11:39:33 EST

On Wed, 20 Feb 2013, Mark Brown wrote:

> On Fri, Feb 15, 2013 at 12:56:33PM +0000, Lee Jones wrote:
> > + if (gpadc->regu)
> > + regulator_disable(gpadc->regu);
> No explanation for this in the changelog and missing error handling like
> this is pretty much always terrible style. Why are we doing this?

No idea, and Jonas is on parental leave.

Perhaps one of the other guys have an explanation?

Lee Jones
Linaro ST-Ericsson Landing Team Lead â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at