Re: [PATCH] dw_dmac: adjust slave_id accordingly to request linebase

From: Vinod Koul
Date: Wed Feb 20 2013 - 01:05:11 EST


On Tue, Feb 19, 2013 at 11:02:24AM +0200, Andy Shevchenko wrote:
> On Mon, 2013-01-28 at 13:04 +0200, Andy Shevchenko wrote:
> > On some hardware configurations we have got the request line with the offset.
> > The patch introduces convert_slave_id() helper for that cases. The request line
> > base is got from the platform device resources provided by the IORESOURCE_DMA
> > type.
>
> Hi, Vinod.
>
> v3.8 is just out, and we have not got any proposal from anyone how to
> make our approach better. So, I'm just wondering about current state.
I was trying to go thru ACPI 5 and see a solution, i think we
- use IORESOURCE_IO, but they have a specfic meaning
- accpet this patch with IORESOURCE_DMA, but again this has specfic dma meaning
too. Just becoz you are in slave-dma driver, doesn't justify use of
IORESOURCE_DMA as well
- use platform_data (somehow get this from CSRT into device parsing logic of
ACPI where you create your platform device and add this in platform data

> Rafael, could you share your opinion about our case with CSRT and
> request line base (perhaps you need to go through the entire thread)?
Sure, do we have anything better than above?

--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/