Re: [PATCH v5 29/45] x86/xen: Use get/put_online_cpus_atomic() toprevent CPU offline
From: Srivatsa S. Bhat
Date: Tue Feb 19 2013 - 13:31:40 EST
On 02/19/2013 11:40 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jan 22, 2013 at 01:10:51PM +0530, Srivatsa S. Bhat wrote:
>> Once stop_machine() is gone from the CPU offline path, we won't be able to
>> depend on preempt_disable() or local_irq_disable() to prevent CPUs from
>> going offline from under us.
>> Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going offline,
>> while invoking from atomic context.
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Weird. I see this in the patch but I don't see it in the header?
Meaning, you didn't get this email at all?
> Did you
> explicitly suppress the CC part?
No.. I sent the entire patchset to a set of email ids and in addition to
that I CC'ed individual patches to the respective maintainers/lists (the
CC: list in the changelog). I used the --auto knob from stgit to do that.
> Anyhow, the patch looks sane enough, thought I need to to run it through
> a test framework just to be on a sure side.
Sure, thank you. But you might want to test the v6 that I sent out
yesterday instead of v5. Oh, wait a min, you didn't get the v6 mail also?
Here it is, for your reference:
Srivatsa S. Bhat
>> Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
>> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
>> Cc: x86@xxxxxxxxxx
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>> Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
>> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/