Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

From: David Miller
Date: Tue Feb 19 2013 - 13:06:16 EST


From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 19 Feb 2013 08:58:44 +0000

> On Tue, 2013-02-19 at 08:03 +0000, Jan Beulich wrote:
>> >>> On 19.02.13 at 06:53, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> > From: Andrew Jones <drjones@xxxxxxxxxx>
>> > Date: Mon, 18 Feb 2013 21:29:20 +0100
>> >
>> >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
>> >> a xenvif_put(). As callers of netbk_fatal_tx_err should only
>> >> have one reference to the vif at this time, then the xenvif_put
>> >> in netbk_fatal_tx_err is one too many.
>> >>
>> >> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
>> >
>> > Applied.
>>
>> But this is wrong from all we can tell,
>
> Yes, please can this be reverted.

Done and I've annotated the revert commit message with as much
information as possible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/