Re: [PATCHv2 1/1] block: IBM RamSan 70/80 driver fixes.

From: Philip J. Kelleher
Date: Tue Feb 19 2013 - 12:58:03 EST


Thanks for the response.

Comments inline.

On Tue, Feb 19, 2013 at 08:57:09AM -0800, Joe Perches wrote:
> On Tue, 2013-02-19 at 10:48 -0600, Philip J. Kelleher wrote:
> > From: Philip J Kelleher <pjk1939@xxxxxxxxxxxxxxxxxx>
> >
> > This patch include a few driver fixes for the IBM RamSan 70/80 driver.
>
> trivial comments:
>
> > diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/config.c linux-block/drivers/block/rsxx/config.c
> []
> > @@ -161,6 +161,17 @@ irqreturn_t rsxx_isr(int irq, void *pdat
> > }
> >
> > /*----------------- Card Event Handler -------------------*/
> > +static char *rsxx_card_state_to_str(unsigned int state)
>
> static const char *
>

Ok.

> > +{
> > + static char *state_strings[] = {
>
> static const char * const state_strings[] = {
>

Ok.

> > + "Unknown", "Shutdown", "Starting", "Formatting",
> > + "Uninitialized", "Good", "Shutting Down",
> > + "Fault", "Read Only Fault", "dStroying"
> > + };
>
> []
>
> > @@ -390,8 +391,13 @@ static int __issue_creg_rw(struct rsxx_c
> > if (st)
> > return st;
> >
> > + /*
> > + * This timeout is neccessary for unresponsive hardware. The additional
>
> One "c" in necessary
>

Haha... Oops. Thanks.

> > + * 20 seconds to used to guarantee that each cregs requests has time to
> > + * complete.
> > + */
> > timeout = msecs_to_jiffies((CREG_TIMEOUT_MSEC *
> > - card->creg_ctrl.q_depth) + 20000);
> > + card->creg_ctrl.q_depth) + 20000);
>
> The alignment was nicer before this change.
> Still using unnecessary parentheses.
>
>

Agreed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/