Re: [PATCH] NET: ath5k, check ath5k_eeprom_mode_from_channel retval

From: Jiri Slaby
Date: Tue Feb 19 2013 - 08:36:21 EST


This is a multi-part message in MIME format.On 02/18/2013 01:47 AM, Nick Kossifidis wrote:
> int
> ath5k_eeprom_mode_from_channel(struct ieee80211_channel *channel)
> {
> switch (channel->hw_value) {
> case AR5K_MODE_11A:
> return AR5K_EEPROM_MODE_11A;
> case AR5K_MODE_11G:
> return AR5K_EEPROM_MODE_11G;
> case AR5K_MODE_11B:
> return AR5K_EEPROM_MODE_11B;
> default:
> return -1;
> }
> }
>
> I think we should just change that default to return 0 instead and add
> an ATH5K_WARN there.

Something like the attached patch? It needs ah to be propagated to
eeprom. If you are fine with that, I'll send it as patch...

thanks,
--
js
suse labs