Re: [PATCH] mfd: wm8994: add missing variable initialization

From: Mark Brown
Date: Tue Feb 19 2013 - 07:18:09 EST


On Tue, Feb 19, 2013 at 09:56:26AM +0900, Jingoo Han wrote:

> - int ret, i, patch_regs;
> + int ret, i, patch_regs = 0;

As with all such changes you really need to explain why it's safe to
just blindly initialise to this particular value and why this isn't just
masking a real issue in the code. Initialising with a random value will
fix the warning but that might just be turning off the compiler's
checks.

Attachment: signature.asc
Description: Digital signature