Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions ondevice attributes

From: Greg KH
Date: Mon Feb 18 2013 - 14:17:28 EST

On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote:
> Whenever a struct device_attribute is registered
> with mismatched permissions - read permission without
> a show routine or write permission without store
> routine - we will issue a big warning so we catch
> those early enough.
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
> This is completely untested. I have only compile tested
> to make sure I'm not breaking anything.
> Greg, do you think this would be nice to have ? I could
> fire up kvm tomorrow and run on a few of my OMAP-based
> boards to make sure it works as expected.

Looks good, but you better fix up all of the big offenders that this
points out, before I apply it, otherwise we will get a ton of bug
reports :)


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at