Re: [PATCH 2/2] power: rx51_battery: Fix reporting correct values

From: Anton Vorontsov
Date: Sat Feb 16 2013 - 16:43:39 EST


On Fri, Feb 15, 2013 at 11:56:50PM +0100, Pali RohÃr wrote:
> Tell twl4030_madc_conversion that this driver needs raw values.
> Driver twl4030_madc has some hardcoded values and conversation
> functions which are incorrect for Nokia RX-51 board. This driver
> rx51_battery expects raw values which convert itself.
>
> This patch fixing values reported by power supply interface.
> Before this patch driver reported always incorrect values on
> 3.8 kernel (sometimes design capacity was negative).
>
> Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>

Assuming you want to pass the series via MFD tree,

Acked-by: Anton Vorontsov <anton@xxxxxxxxxx>

Thanks!

> ---
> drivers/power/rx51_battery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/rx51_battery.c b/drivers/power/rx51_battery.c
> index 527d256..d1e17b0 100644
> --- a/drivers/power/rx51_battery.c
> +++ b/drivers/power/rx51_battery.c
> @@ -42,6 +42,7 @@ static int rx51_battery_read_adc(int channel)
> req.method = TWL4030_MADC_SW1;
> req.func_cb = NULL;
> req.type = TWL4030_MADC_WAIT;
> + req.raw = true;
>
> if (twl4030_madc_conversion(&req) <= 0)
> return -ENODATA;
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/