Re: [PATCH 4/5] freezer: clear fake signal on exit from__refrigerator

From: Oleg Nesterov
Date: Sat Feb 16 2013 - 12:08:11 EST

On 02/16, Mandeep Singh Baines wrote:
> --- a/kernel/freezer.c
> +++ b/kernel/freezer.c
> @@ -81,6 +81,9 @@ bool __refrigerator(bool check_kthr_stop)
> */
> set_current_state(save);
> + /* Clear fake signal from freeze_task(). */
> + recalc_sigpending();

NACK. We can't do this lockless.

And I am not sure we should reinstantiate it here.

The coredumping is "special". It is not a kernel thread, but it does
a lot of in-kernel activity and never returns to user-mode. If it play
games with the freezer, perhaps it should take care itself...



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at