[PATCH] regulator: tps6586x: Having slew rate settings for otherthan SM0/1 is not fatal

From: Axel Lin
Date: Sat Feb 16 2013 - 06:51:29 EST

Ignore the setting and show "Only SM0/SM1 can set slew rate" warning is enough,
then we can return 0 instead of -EINVAL in tps6586x_regulator_set_slew_rate().

Otherwise, probe() fails.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
drivers/regulator/tps6586x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
index e68382d..51da3f9 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -246,7 +246,7 @@ static int tps6586x_regulator_set_slew_rate(struct platform_device *pdev,
dev_warn(&pdev->dev, "Only SM0/SM1 can set slew rate\n");
- return -EINVAL;
+ return 0;

return tps6586x_write(parent, reg,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/