Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag toindicate pulldown on EN input

From: Haojian Zhuang
Date: Sat Feb 16 2013 - 00:57:36 EST


On Sat, Feb 16, 2013 at 1:35 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
>
>> I think that enable_pulldown is a little hard to understand. How about
>> change
>> the name, like set_to_disable or something else?
>
>
> How about "enable_invert"?
> ( We have ena_gpio_invert setting for GPIO controlled enable lines )
>
> Then I'll update the comments to:
> @enable_invert: A flag to indicate set enable_mask bits to disable when
> using
> regulator_enable_regmap and friends APIs.
>
> Axel

enable_is_inverted is better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/