Re: [PATCH v2] rtc: max8997: Add driver for max8997 rtc.

[jonghwa3 . lee]

On 2013ë 02ì 08ì 06:44, Andrew Morton wrote:
> On Thu, 07 Feb 2013 20:01:27 +0900
> Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx> wrote:
> 
>> This patch adds rtc driver for Maxim 8997 multifunction chip.
>> Max8997 has rtc module in it. and it can be used for timekeeping
>> clock and system alarm. It provide various operational mode those are
>> BCD/binary, 24/12hour, am/pm. Driver sets binary/24/ for default.
>> Maxim 8997 also supports SMPL(Sudden Momentary Power Loss), WTSR
>> (Watchdog Timeout and Software Reset).
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
>> ---
>> v2
>>  - Add module parameter to enable/disable WTSR, SMPL fuction.
>>  - Add unregister_rtc_device() for accidental exit in probing.
>>
>> ...
>>
>> +/* Module parameter for WTSR function control */
>> +static int wtsr_en = 1;
>> +module_param(wtsr_en, int, 0444);
>> +MODULE_PARM_DESC(wtsr_en, "Wachdog Timeout & Sofware Reset (default=on)");
>> +/* Module parameter for SMPL function control */
>> +static int smpl_en = 1;
>> +module_param(smpl_en, int, 0444);
>> +MODULE_PARM_DESC(smpl_en, "Sudden Momentary Power Loss (default=on)");
> 
> "default=on" is interesting.  For what reasons would a user ever want
> to set this "off"?  Can we just remove the options and leave these
> things enabled all the time for everyone?
>

System with WTSR will be postponed to reset more than 58.6ms(250 ~ 1000ms) even if AP sends
POWERHOLD signal low. (By default(without WTSR) it keeps PMIC on 58.6ms , then re-check the
POWERHOLD signal to determine whether it needs PMIC off)
And with SMPL option enabled, system will be automatically re-boot when power has been recovered
before SMPL's timer is expired.

Those all functions are just optional not significant. And someone may not want to them, so
I think the better idea is leave it selectable. If you don't thinks so, I remove options and
keep it enabled for all.

Thanks,
Jonghwa.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/