Re: [char-misc-next 01/11] mei: bus: Initial MEI bus typeimplementation

From: Samuel Ortiz
Date: Thu Feb 07 2013 - 17:59:29 EST


On Thu, Feb 07, 2013 at 10:41:06PM +0000, Arnd Bergmann wrote:
> On Thursday 07 February 2013, Tomas Winkler wrote:
> > +}
> > +EXPORT_SYMBOL(mei_add_device);
> > +
> > +void mei_remove_device(struct mei_bus_client *client)
> > +{
> > + device_unregister(&client->dev);
> > +}
> > +EXPORT_SYMBOL(mei_remove_device);
>
> One more point: did you intentionally pick EXPORT_SYMBOL over
> EXPORT_SYMBOL_GPL here?
No, I didn't.

> It is your decision as the copyright
> holder, but the default is often EXPORT_SYMBOL_GPL these
> days, to make it clear that you don't expect closed source
> drivers to plug in there.
I'll fix that if Tomas is ok with it.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/