Re: [PATCH] intel_iommu: Disable vfio and kvm interrupt assignmentwhen unsafe

From: David Woodhouse
Date: Thu Feb 07 2013 - 16:02:52 EST


On Thu, 2013-02-07 at 18:27 +0100, Joerg Roedel wrote:
>
> Second, I think that it should be a pr_warn instead of a full WARN. When
> IRQ remapping could not be enabled it's most likely because of the BIOS
> or the hardware. So a message in the kernel log will do and the
> backtrace provides no additional value.

Backtraces add visibility and have proven to be extremely useful in the
past for getting people to actually *fix* broken BIOSes.

When kerneloops.org was running, it also gave very good statistics which
helped to apply pressure.

--
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature