Re: [PATCH 08/10] USB: EHCI: make ehci-vt8500 a separate driver

From: Tony Prisk
Date: Thu Feb 07 2013 - 13:54:24 EST


On Thu, 2013-02-07 at 23:04 +0530, manjunath.goudar@xxxxxxxxxx wrote:
> From: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx>
>
> Separate the vt8500 host controller driver from ehci-hcd host code
> into its own driver module.
>
> Signed-off-by: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Tony Prisk <linux@xxxxxxxxxxxxxxx>
> Cc: Alexey Charkov <alchark@xxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/usb/host/Kconfig | 8 +++++
> drivers/usb/host/Makefile | 1 +
> drivers/usb/host/ehci-hcd.c | 5 ---
> drivers/usb/host/ehci-vt8500.c | 73 ++++++++++++++++++----------------------
> 4 files changed, 42 insertions(+), 45 deletions(-)
>
...
> diff --git a/drivers/usb/host/ehci-vt8500.c b/drivers/usb/host/ehci-vt8500.c
> index 11695d5..ff4e3ae 100644
> --- a/drivers/usb/host/ehci-vt8500.c
> +++ b/drivers/usb/host/ehci-vt8500.c
> @@ -16,52 +16,25 @@
...
> +MODULE_DESCRIPTION(DRIVER_DESC);
> +MODULE_AUTHOR("Alexey Charkov");
> +MODULE_LICENSE("GPL");
Should be "GPL v2" as per the license header.

> MODULE_ALIAS("platform:vt8500-ehci");
> MODULE_DEVICE_TABLE(of, vt8500_ehci_ids);

Regards
Tony Prisk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/