Re: [PATCH 1/3] stop_machine: check work->done while handlingenqueued works

[Hillf Danton]

Hello Tejun

On Thu, Feb 7, 2013 at 2:46 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> @@ -279,8 +281,6 @@ repeat:
>>               preempt_disable();
>>
>>               ret = fn(arg);
>> -             if (ret)
>> -                     done->ret = ret;
>
> If this is meant as a pure cleanup, I'm not sure it's an improvement.
> You own your cpu_stop_done until you call cpu_stop_signal_done() on
> it, so I don't think there's anything wrong with the current code.
> The new code is different, not necessarily better.

The comment just above cpu_stop_signal_done()
says it is not certain that the input done is valid, so
I did this work.
Plus works enqueued through stop_one_cpu_nowait()
do carry no done.

Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/