Re: [PATCH 0/2] perf stat: add per processor socket count aggregation

From: Stephane Eranian
Date: Thu Feb 07 2013 - 02:36:08 EST


On Thu, Feb 7, 2013 at 3:31 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> Hi Stephane,
>
> On Wed, 6 Feb 2013 15:46:00 +0100, Stephane Eranian wrote:
>> This patch adds per-processor socket count aggregation
>> for system-wide mode measurements. This is a useful
>> mode to detect imbalance between sockets for uniform
>> workloads.
>>
>> To enable this mode, use --aggr-socket in addition
>> to -a. (system-wide). This mode can be combined with
>> interval printing.
>>
>> The output includes the socket number and the number
>> of online processors on that socket. This is useful
>> to gauge the amount of aggregation.
>>
>> # ./perf stat -I 1000 -a --aggr-socket -e cycles sleep 2
>> # time socket cpus counts events
>> 1.000097680 S0 4 5,788,785 cycles
>> 2.000379943 S0 4 27,361,546 cycles
>> 2.001167808 S0 4 818,275 cycles
>
> Can it be genericized to support arbitrary cpu topology like per-core,
> per-numa-node or something?
>
Yes, we could. I think that could be useful too. I will look into
this. But please don't
ask for stupid scripting to do this. We need to keep things simple. I
think perf has
gotten to be a very complex tool, hard to read code, more difficult to maintain.

As for the particular feature, I know how to make it work on x86, but
it is not clear to me how portable is the sysfs topology tree? For instance,
on PPC, would that work? Worst case, we can make the topology routines
arch specific and use weak functions to cover any architecture which does
not have topology info.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/