Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0to gigabit ethernet adapter driver

[Stephen Hemminger]

On Thu,  7 Feb 2013 12:36:34 +0800
Freddy Xin <freddy@xxxxxxxxxxx> wrote:

> +struct {unsigned char ctrl, timer_l, timer_h, size, ifg; }
> +AX88179_BULKIN_SIZE[] =	{
> +	{7, 0x4f, 0,	0x12, 0xff},
> +	{7, 0xf0, 1,	0x15, 0xff},
> +	{7, 0xae, 7,	0x18, 0xff},
> +	{7, 0xcc, 0x4c, 0x18, 8},
> +};

Better to make it static, const, and add a couple
of line breaks.

static const struct {
      unsigned char ctrl, timer_l, timer_h, size, ifg;
} AX88179_BULKIN_SIZE[] =	{
	{7, 0x4f, 0,	0x12, 0xff},
	{7, 0xf0, 1,	0x15, 0xff},
	{7, 0xae, 7,	0x18, 0xff},
	{7, 0xcc, 0x4c, 0x18, 8},
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/