[RFC][PATCH] PAGE_OWNER now depends on STACKTRACE_SUPPORT

From: Dave Hansen
Date: Wed Feb 06 2013 - 12:49:06 EST



One of the enhancements I made to the PAGE_OWNER code was to make
it use the generic stack trace support. However, there are some
architectures that do not support it, like m68k. So, make
PAGE_OWNER also depend on having STACKTRACE_SUPPORT.

This isn't ideal since it restricts the number of places
PAGE_OWNER runs now, but it at least hits all the major
architectures.

tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 83b324c5ff5cca85bbeb2ba913d465f108afe472
commit: 2a561c9d47c295ed91984c2b916a4dd450ee0279 [484/499] debugging-keep-track-of-page-owners-fix
config: make ARCH=m68k allmodconfig

All warnings:

warning: (PAGE_OWNER && STACK_TRACER && BLK_DEV_IO_TRACE && KMEMCHECK) selects STACKTRACE which has unmet direct dependencies (STACKTRACE_SUPPORT)

Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
---

linux-2.6.git-dave/lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT lib/Kconfig.debug
--- linux-2.6.git/lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT 2013-02-06 09:44:01.372619511 -0800
+++ linux-2.6.git-dave/lib/Kconfig.debug 2013-02-06 09:44:10.648711604 -0800
@@ -101,7 +101,7 @@ config UNUSED_SYMBOLS

config PAGE_OWNER
bool "Track page owner"
- depends on DEBUG_KERNEL
+ depends on DEBUG_KERNEL && STACKTRACE_SUPPORT
select DEBUG_FS
select STACKTRACE
help
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/