[PATCH 4/6] kvm tools: powerpc: Fix buglet in xics_init() handling of nrcpus

From: Michael Ellerman
Date: Wed Feb 06 2013 - 03:20:58 EST


In xics_init() we set the maximum server to kvm->nrcpus, and then set
the nr_servers using maximum server + 1.

That is off by one, in the harmless direction.

Simplify it to just set nr_servers = kvm->nrcpus.

Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
---
tools/kvm/powerpc/xics.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/kvm/powerpc/xics.c b/tools/kvm/powerpc/xics.c
index d4b5caa..cf64a08 100644
--- a/tools/kvm/powerpc/xics.c
+++ b/tools/kvm/powerpc/xics.c
@@ -445,16 +445,13 @@ static void rtas_int_on(struct kvm_cpu *vcpu, uint32_t token,

static int xics_init(struct kvm *kvm)
{
- int max_server_num;
unsigned int i;
struct icp_state *icp;
struct ics_state *ics;
int j;

- max_server_num = kvm->nrcpus;
-
icp = malloc(sizeof(*icp));
- icp->nr_servers = max_server_num + 1;
+ icp->nr_servers = kvm->nrcpus;
icp->ss = malloc(icp->nr_servers * sizeof(struct icp_server_state));

for (i = 0; i < icp->nr_servers; i++) {
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/