Re: [PATCH 4/7] cpufreq: Do not track governor name for scalingdrivers with internal governors.

From: Viresh Kumar
Date: Tue Feb 05 2013 - 20:50:41 EST


On Tue, Feb 5, 2013 at 11:54 PM, <dirk.brandewie@xxxxxxxxx> wrote:
> From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
>
> Scaling drivers that implement internal governors do not have governor
> structures assocaited with them. Only track the name of the governor
> associated with the CPU if the driver does not implement
> cpufreq_driver.setpolicy()
>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index d8daa4b..622e282 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1050,7 +1050,9 @@ static int __cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif
> __cpufreq_governor(data, CPUFREQ_GOV_STOP);
>
> #ifdef CONFIG_HOTPLUG_CPU
> - strncpy(per_cpu(cpufreq_cpu_governor, cpu), data->governor->name,
> + if (!cpufreq_driver->setpolicy)
> + strncpy(per_cpu(cpufreq_cpu_governor, cpu),
> + data->governor->name,
> CPUFREQ_NAME_LEN);

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/