Re: [PATCH 0/2] tty: metag_da: fix flipping after tty changes

From: James Hogan
Date: Tue Feb 05 2013 - 10:24:00 EST


On 05/02/13 15:15, Jiri Slaby wrote:
> On 02/05/2013 03:40 PM, James Hogan wrote:
>> The first patch fixes up tty/metag_da after Jiri's changes, "TTY: switch
>> tty_flip_buffer_push" and "TTY: convert more flipping functions",
>> switched tty_flip_buffer_push() and tty_prepare_flip_string() to take
>> tty_port rather than a tty_struct.
>>
>> The second just refactors slightly as a result of it.
>>
>> How is this sort of thing usually handled? I suppose either I squash it
>> into the original driver and base it on tty-next, move it into tty-next,
>> or just fix it up afterwards?
>>
>> James Hogan (2):
>> tty: metag_da: update flip functions to use tty_port
>> tty: metag_da: avoid getting tty kref in dashtty_timer()
>
> They both look good. You can add my:
> Acked-by: Jiri Slaby <jslaby@xxxxxxx>
> if you want.

Thanks Jiri

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/