Re: Revert "console: implement lockdep support for console_lock"

[Sedat Dilek]

On Tue, Feb 5, 2013 at 11:47 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> On Fri, Feb 1, 2013 at 9:42 AM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
>> On Fri, Feb 1, 2013 at 9:21 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>>> people having the fbcon-locking-fixes [1] in their local GIT tree can
>>> revert this change?
>>
>> Yeah, if you have all the fixes reverting this is fine and appreciated
>> to increase testing. Dave will probably push the revert himself to
>> drm-next soon.
>
> When will that happen: drm-next inclusion?
>
> Just FYI:
> Pulling fbcon-locking-fixes into Linux-Next (next-20130205) shows some
> ugly UTF-8 mismatch, means "fb: rework locking to fix lock ordering on
> takeover" is not the same patch as in -next.
> Just wanna let you know.
>
> It would be good to inform Andrew and Stephen when this happened, so
> Andrew can drop the two fb-fixes from his mmotm-tree.
>

Attached the UTF-8 "mismatch" in vt.c.

- Sedat -

> Thanks!
>
> - Sedat -
>
>> -Daniel
>>
>>>
>>> commit ff0d05bf73620eb7dc8aee7423e992ef87870bdf
>>> Refs: v3.8-rc5-194-gff0d05b
>>> Author:     Dave Airlie <airlied@xxxxxxxxx>
>>> AuthorDate: Thu Jan 31 14:27:03 2013 +1100
>>> Commit:     Dave Airlie <airlied@xxxxxxxxx>
>>> CommitDate: Thu Jan 31 15:46:56 2013 +1100
>>>
>>>     Revert "console: implement lockdep support for console_lock"
>>>
>>>     This reverts commit daee779718a319ff9f83e1ba3339334ac650bb22.
>>>
>>>     I'll requeue this after the console locking fixes, so lockdep
>>>     is useful again for people until fbcon is fixed.
>>>
>>>     Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
>>>
>>> Thanks!
>>>
>>> Regards,
>>> - Sedat
>>>
>>> [1] http://cgit.freedesktop.org/~airlied/linux/log/?h=fbcon-locking-fixes
>>
>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Attachment: VT_C_UTF-8_CRAP.diff
Description: Binary data