Re: [PATCH v2 1/4] acpi: move x86/mm/srat.c tox86/kernel/acpi/srat.c

[li guang]

å 2013-02-04äç 21:35 -0800ïDavid Rientjesåéï
> On Tue, 5 Feb 2013, liguang wrote:
> 
> > srat table should present only on acpi domain,
> > seems mm/ is not the right place for it.
> > 
> > Reviewed-by: David Rientjes <rientjes@xxxxxxxxxx>
> 
> I certainly didn't review this, please read 
> Documentation/SubmittingPatches.
> 
> > Signed-off-by: liguang <lig.fnst@xxxxxxxxxxxxxx>
> 
> Couple of issues with this:
> 
>  - it doesn't include your followup change "acpi: change Makefile for
>    srat.c building" which is required for this to build, please fold it in 
>    and repost,
> 
>  - there is whitespace damage, we use tabs for indentation in Makefiles,
> 
>  - you're basing your patches on Linus' tree when arch/x86/mm/srat has
>    changed in linux-next (15 insertions(+), 14 deletions(-)), please 
>    rebase this on the linux-next tree at git.kernel.org.
> 
> Otherwise, looks good.

OK, I'll rebase on linux-next.
Thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/