Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

From: Stephen Warren
Date: Mon Feb 04 2013 - 16:01:19 EST


On 02/04/2013 03:45 AM, Peter De Schrijver wrote:
> On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote:

>>> + /* xusb_hs_src */
>>> + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> + val |= BIT(25); /* always select PLLU_60M */
>>> + writel(val, clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> +
>>> + clk = clk_register_fixed_factor(NULL, "xusb_hs_src", "pll_u_60M", 0,
>>> + 1, 1);
>>> + clks[xusb_hs_src] = clk;
>>> +
>>
>> With device tree we can directly use pll_u_60M, no need to register
>> clock with fixed factor 1.
>
> This is true for now. In the future these clocks will need to be dvfs aware
> though. I think it makes sense to have a separate clock then?

Why does DVFS-awareness require it to be a different clock/ID?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/