[patch] config: fix make kvmconfig
From: David Rientjes
Date: Mon Feb 04 2013 - 13:20:20 EST
make kvmconfig selects CONFIG_SERIAL_8250 without selecting its
dependencies causing some configs to fail:
drivers/tty/serial/8250/8250.c:57:32: error: 'CONFIG_SERIAL_8250_RUNTIME_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c:2712:47: error: 'CONFIG_SERIAL_8250_NR_UARTS' undeclared here (not in a function)
drivers/tty/serial/8250/8250.c: In function 'serial8250_console_write':
drivers/tty/serial/8250/8250.c:2843:10: error: 'struct uart_port' has no member named 'sysrq'
drivers/tty/serial/8250/8250.c: In function 'early_serial_setup':
drivers/tty/serial/8250/8250.c:2971:20: error: negative width in bit-field '<anonymous>'
drivers/tty/serial/8250/8250.c: At top level:
drivers/tty/serial/8250/8250.c:2712:30: warning: 'serial8250_ports' defined but not used [-Wunused-variable]
Fix this by selecting CONFIG_TTY as well, which CONFIG_SERIAL_8250
requires.
Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
---
Ok, so this patch has been sitting in linux-next for well over a year and
has had to be fixed several times with follow up commits similar to this.
Linus hasn't pulled kvmtool, so I'm wondering why we need to keep this
around in the first place?
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6979498..f9459b3 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -606,6 +606,7 @@ config KVMTOOL_TEST_ENABLE
select NETWORK_FILESYSTEMS
select INET
select EXPERIMENTAL
+ select TTY
select SERIAL_8250
select SERIAL_8250_CONSOLE
select IP_PNP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/