Re: [PATCH] rcu: Have rcu torture test select trace_clock

[Paul E. McKenney]

On Mon, Feb 04, 2013 at 10:52:21AM -0500, Steven Rostedt wrote:
> The rcu torture test uses trace_clock, and requires that it be built
> into the kernel. If it is not, then we get the following build error:
> 
> ERROR: "trace_clock_local" [kernel/rcutorture.ko] undefined!
> 
> Reported-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

This would work, but would unnecessarily force trace_clock_local()
to be defined when RCU tracing is disabled.  So, would the alternative
patch I posted work for you?

							Thanx, Paul

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4057127..b542477 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -942,6 +942,7 @@ config SPARSE_RCU_POINTER
>  config RCU_TORTURE_TEST
>  	tristate "torture tests for RCU"
>  	depends on DEBUG_KERNEL
> +	select TRACE_CLOCK
>  	default n
>  	help
>  	  This option provides a kernel module that runs torture tests
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/