Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

[Dan Carpenter]

On Fri, Feb 01, 2013 at 12:48:16AM +0200, Stratos Karafotis wrote:
> I will fix it.

I don't know the status of this driver.

But in general the patch should have been divided up into smaller
changes and sent as a patchset.  It creates a bunch of messy new
globals where it would have been cleaner to use function parameters.
Don't introduce new calls to lowmem_print() because we have better
debugging facilities already in the kernel and don't need more.

Btw, the more things you put into one patch, the more there is to
complain about and the less likely it is to be merged.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/