Re: [PATCH 3/4] Export blk_fill_rwbs()

From: Li Zefan
Date: Thu Jan 31 2013 - 22:57:55 EST


on 2013/2/1 11:48, Steven Rostedt wrote:
> Li,
>
> Can you give an Ack or Nack for this.
>

I think this patch shouldn't go into upstream without bcache code. We don't
export symbols for out of tree code.

> Thanks,
>
> -- Steve
>
>
> On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote:
>> Exported so it can be used by bcache's tracepoints
>>
>> Signed-off-by: Kent Overstreet <koverstreet@xxxxxxxxxx>
>> CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
>> CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>> CC: Ingo Molnar <mingo@xxxxxxxxxx>
>> ---
>> kernel/trace/blktrace.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
>> index c0bd030..dbe1667 100644
>> --- a/kernel/trace/blktrace.c
>> +++ b/kernel/trace/blktrace.c
>> @@ -1806,6 +1806,7 @@ void blk_fill_rwbs(char *rwbs, u32 rw, int bytes)
>>
>> rwbs[i] = '\0';
>> }
>> +EXPORT_SYMBOL_GPL(blk_fill_rwbs);
>>
>> #endif /* CONFIG_EVENT_TRACING */
>>
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/