Re: [PATCH 1/1] ASoC: Ux500: Fix build error pertaining to missinginclude file

From: Lee Jones
Date: Thu Jan 31 2013 - 09:21:29 EST


On Thu, 31 Jan 2013, Mark Brown wrote:

> On Thu, Jan 31, 2013 at 02:07:35PM +0000, Lee Jones wrote:
> > On Thu, 31 Jan 2013, Mark Brown wrote:
>
> > > I'm a bit surprised the compiler would change something like that, I'd
> > > expect it to be more the build system.
>
> > You've lost me.
>
> > When I compile this file it succeeds. When the person who reported
> > this bug compiles, it fails with the error above.
>
> > mop500_ab8500.h is actually in the same directory as the file
> > including it, so it should by rights be encapsulated in "" and not <>,
> > right?
>
> Yes, it should - but this is also something that can be overridden by
> the build system. It'd seem surprising for a compiler vendor to change
> their behaviour here as there's limited benefit in changing and much
> potential for error.

Ah, got you.

Are you going to take the patch?

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/