Re: [PATCH 8/8] cputime: Safely read cputime of full dynticks CPUs

[Sedat Dilek]

On Thu, Jan 31, 2013 at 11:12 AM, Frederic Weisbecker
<fweisbec@xxxxxxxxx> wrote:
> 2013/1/31 Sedat Dilek <sedat.dilek@xxxxxxxxx>:
>> On Thu, Jan 31, 2013 at 1:38 AM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>>> 2013/1/28 Sedat Dilek <sedat.dilek@xxxxxxxxx>:
>>>> On Mon, Jan 28, 2013 at 8:04 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>>>>> While remotely reading the cputime of a task running in a
>>>>> full dynticks CPU, the values stored in utime/stime fields
>>>>> of struct task_struct may be stale. Its values may be those
>>>>> of the last kernel <-> user transition time snapshot and
>>>>> we need to add the tickless time spent since this snapshot.
>>>>>
>>>>> To fix this, flush the cputime of the dynticks CPUs on
>>>>> kernel <-> user transition and record the time / context
>>>>> where we did this. Then on top of this snapshot and the current
>>>>> time, perform the fixup on the reader side from task_times()
>>>>> accessors.
>>>>>
>>>>> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>>>>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>>>>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>>>>> Cc: Li Zhong <zhong@xxxxxxxxxxxxxxxxxx>
>>>>> Cc: Namhyung Kim <namhyung.kim@xxxxxxx>
>>>>> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
>>>>> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
>>>>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>>>>> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
>>>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>>>> [fixed kvm module related build errors]
>>>>> Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>>>>>
>>>>
>>>> Can you explain a bit what is the difference between "3.8-rc4-nohz3"
>>>> and "full-dynticks-cputime-for-mingo" patchsets?
>>>
>>> 3.8-rc4-nohz3 is the latest experimental tree that implements full
>>> dynticks. It includes an earlier version of full dynticks cputime and
>>> many other things to make the full dynticks possible: nohz printk,
>>> many tweaks on the scheduler and timers...etc
>>>
>>
>> So, dynticks-cputime will go into 3.9?
>
> I can't say "will" but I hope.
>
>> What about the other parts? Coming later?
>
> May be the printk part will go into 3.9. Linus ignored my pull request
> so may be we'll get more chances if it goes through Ingo.
>

I still dunno all parts of dynticks and their correlation.
AFAICS they seem to be independent, can't say if it is "complete" with
dynticks-cputime-only.

Was that dynticks stuff ever advertised for Linux-Next inclusion?
Or wnt through any "mingo-next" tree?
AFAICS, better chances these ways!

- Sedat -

> And the rest will come later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/