Re: [PATCH] cpufreq: governors: implement generic policy_is_shared

[Viresh Kumar]

On 31 January 2013 13:44, Fabio Baltieri <fabio.baltieri@xxxxxxxxxx> wrote:
> Implement a generic helper function policy_is_shared() to replace the
> current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be
> used by code other than cpufreq governors.
>
> Suggested-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@xxxxxxxxxx>
> ---
>  drivers/cpufreq/cpufreq_conservative.c | 2 +-
>  drivers/cpufreq/cpufreq_governor.c     | 8 --------
>  drivers/cpufreq/cpufreq_governor.h     | 1 -
>  drivers/cpufreq/cpufreq_ondemand.c     | 2 +-
>  include/linux/cpufreq.h                | 5 +++++

Great,

But, you missed few places:

drivers/cpufreq/acpi-cpufreq.c:        if (bios_with_sw_any_bug &&
cpumask_weight(policy->cpus) == 1) {
drivers/cpufreq/cpufreq_stats.c:       if (policy &&
(cpumask_weight(policy->cpus) == 1)) {

get these fixed too and add my

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/