Re: [PATCH V3] regulators: anatop: add set_voltage_time_sel interface

From: Mark Brown
Date: Thu Jan 31 2013 - 01:40:57 EST


On Thu, Jan 31, 2013 at 11:23:53AM -0500, Anson Huang wrote:
> some of anatop's regulators(cpu, vddpu and vddsoc) have
> register settings about LDO's step time, which will impact
> the LDO ramp up speed, need to use set_voltage_time_sel
> interface to add necessary delay everytime LDOs' voltage
> is increased.

Applied, thanks. It does seem like...

> +#define LDO_RAMP_UP_UNIT_IN_CYCLES 64 /* 64 cycles per step */
> +#define LDO_RAMP_UP_FREQ_IN_MHZ 24 /* cycle based on 24M OSC */

...this ought to go into device tree too (at least the oscillator
frequency).

Please do also use subject lines appropriate to the subsystem.

Attachment: signature.asc
Description: Digital signature