Re: [PATCH] ptp: PTP_1588_CLOCK_PCH depends on x86

From: Richard Cochran
Date: Wed Jan 30 2013 - 14:02:24 EST


On Wed, Jan 30, 2013 at 12:31:01PM -0500, Jeff Mahoney wrote:
> The EG20T PCH is only compatible with Intel Atom processors so it
> should depend on x86.

Yes, there is something wrong with PTP_1588_CLOCK_PCH. The last
several times I did 'make oldconfig' for various configs, it asked me
whether to enable this 'new' option. That is really annoying,
especially with non-atom and non-x86 builds.

Ben, you removed the PCH_GBE dependency in 18d359ce. Are you sure that
was the right thing to do?

Thanks,
Richard


> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
> ---
> drivers/ptp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -72,6 +72,7 @@ config DP83640_PHY
>
> config PTP_1588_CLOCK_PCH
> tristate "Intel PCH EG20T as PTP clock"
> + depends on X86
> select PTP_1588_CLOCK
> help
> This driver adds support for using the PCH EG20T as a PTP
>
> --
> Jeff Mahoney
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/