Re: [PATCH v3 43/44] tty/metag_da: Add metag DA TTY driver

[Greg Kroah-Hartman]

On Fri, Jan 25, 2013 at 11:36:53AM +0000, James Hogan wrote:
> Hi,
> 
> On 14/01/13 10:54, James Hogan wrote:
> > Here's a new version addressing Jiri's feedback.
> > 
> > Add a TTY driver for communicating over a Meta DA (Debug Adapter)
> > channel using the bios channel SWITCH operation.
> > 
> > Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> > Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Jiri Slaby <jslaby@xxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> > Cc: Cesar Eduardo Barros <cesarb@xxxxxxxxxx>
> > Cc: Joe Perches <joe@xxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> 
> If this looks okay, I'd appreciate if somebody could Ack it.
> 
> I have some further patches ready to simplify the code around
> tty_prepare_flip_string and tty_flip_buffer_push to avoid taking a tty
> kref, after Jiri's changes in that area in linux-next. I guess these can
> be applied once both sets of changes are merged.

At first glance, it looks good to me:

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/