Re: [PATCH] dw_dmac: adjust slave_id accordingly to request linebase

From: Andy Shevchenko
Date: Wed Jan 30 2013 - 03:08:15 EST


On Wed, 2013-01-30 at 13:31 +0530, Viresh Kumar wrote:
> On Wed, Jan 30, 2013 at 1:02 PM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > We get a device from the ACPI CSRT table. During enumeration we don't
> > know what kind of the device it is. From the enumeration point of view
> > each device enumerated from CSRT is a platform device (see
> > drivers/acpi/csrt.c for the details).
> >
> > That's why we have to pass this info somehow to the DMAC driver. And
> > like Mika already mentioned we have no other generic way except
> > IORESOURCE_DMA. If you have something better in mind, please share. We
> > could adopt our code then.
>
> You don't need this in DT case too?

I think no. It seems the DT has a proper backlink from the slave device
to the dmac ("dma-names" property if I understood it correctly).

> Or only for ACPI case?

ACPI 5 case only until now.
We would like to initiate the proposal to the ACPI specification
team/whoever to have this part designed better in next versions.

> I think "Yes" is the answer of both the questions. If so, then you
> can keep it this way or add another variable in platform data.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/