Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linkerscript

[Sam Ravnborg]

On Tue, Jan 29, 2013 at 07:15:07PM +0530, Vineet Gupta wrote:
> On Tuesday 29 January 2013 12:14 AM, Sam Ravnborg wrote:
> > On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote:
> >> Hi Sam,
> >>
> >> On Thursday 24 January 2013 04:20 PM, Vineet Gupta wrote:
> >>> Arnd in his review pointed out that arch Kconfig organisation has several
> >>> deficiencies:
> >>>
> >>> * Build time entries for things which can be runtime extracted from DT
> >>>   (e.g. SDRAM size, core clk frequency..)
> >>> * Not multi-platform-image-build friendly (choice .. endchoice constructs)
> >>> * cpu variants support (750/770) is exclusive.
> >>>
> >>> The first 2 have been fixed in subsequent patches.
> >>> Due to the nature of the 750 and 770, it is not possible to build for
> >>> both together, w/o special runtime glue code which would hurt
> >>> performance.
> >>>
> >>> Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx>
> >>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> >>> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Looks good - all former comments addressed, and nothing were jumping
> > into my eyes now.
> > Many existing architectures looks worse from the build stuff perspective...
> >
> > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> >
> > 	Sam
> 
> Thx Sam. I have a following one liner change to the version you reviewed. Will it
> be OK to add your ACK despite that or do I need to send the updated patch for you
> to take a look again.
OK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/