RE: [PATCH] x86: Hyper-V: register clocksource only if itsadvertised

From: Stefano Stabellini
Date: Tue Jan 29 2013 - 11:14:48 EST


On Tue, 29 Jan 2013, KY Srinivasan wrote:
> > > I agree with you that your patch is valid for making the Hyper-V code more
> > robust but not for dealing
> > > with general issue of Xen emulating Hyper-V.
> >
> > What "general issue" would that be?
>
> Not all Hyper-V specific features are advertised via a feature bit. For instance, we need to reserve
> an IDT entry to have VMBUS interrupts delivered on a per-CPU basis and this reservation is done
> after confirming that we are running on Hyper-V. With Xen emulating Hyper-V, we have an issue.
> Since Hyper-V will never emulate Xen, I am going to add a check in the Hyper-V detection code to
> deal with this issue.

I personally think that it would be much nicer to have a feature flag
somewhere to advertise per-CPU VMBUS interrupts.
However adding a check in the Hyper-V detection code is OK too for me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/