Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

From: Viresh Kumar
Date: Tue Jan 29 2013 - 10:27:33 EST


On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> We had a discusssion about this with Andy as well. The thing is that there
> is no way in current resource to pass DMA request line numbers supported by
> the controller to the driver in a generic way. We on the other hand have to
> deal this somehow as we have a shared DMA controller on Lynxpoint where the
> offset will start from 16 (but it might be something else as well).
>
> Is there something which limits the usage of IORESOUCE_DMA to be only
> usable for ISA DMA channels?

Andy,

Why do we need this request_line_base? Why not program the actual value
directly into the slave structure (base + offset)?

In case it is required, add it in platform data field or can add DT
binding for it.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/