Re: [PATCH] 8250/16?50: Add support for Broadcom TruManageredirected serial port

[Greg KH]

On Tue, Jan 29, 2013 at 05:06:24PM +0200, Alexander Shishkin wrote:
> Michael Chan <mchan@xxxxxxxxxxxx> writes:
> 
> > From: Stephen Hurd <shurd@xxxxxxxxxxxx>
> >
> > Add support for the UART device present in Broadcom TruManage capable
> > NetXtreme chips (ie: 5761m 5762, and 5725).
> >
> > This implementation has a hidden transmit FIFO, so running in single-byte
> > interrupt mode results in too many interrupts.  The UART_CAP_HFIFO
> > capability was added to track this.  It continues to reload the THR as long
> > as the THRE and TSRE bits are set in the LSR up to a specified limit (1024
> > is used here).
> >
> > Signed-off-by: Stephen Hurd <shurd@xxxxxxxxxxxx>
> > Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx>
> 
> Greg, this looks like a new feature, yet it was applied to -rc5 and
> stable. Any reason for that? I'm asking because this patch doesn't seem
> to have received enough reviewing/testing:
> 
> [skip platform bits]
> 
> > diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> > index 78f99d9..2c6c85f 100644
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -50,7 +50,8 @@
> >  #define PORT_LPC3220	22	/* NXP LPC32xx SoC "Standard" UART */
> >  #define PORT_8250_CIR	23	/* CIR infrared port, has its own driver */
> >  #define PORT_XR17V35X	24	/* Exar XR17V35x UARTs */
> > -#define PORT_MAX_8250	24	/* max port ID */
> > +#define PORT_BRCM_TRUMANAGE	24
> > +#define PORT_MAX_8250	25	/* max port ID */
> 
> This is a bug, TRUMANAGE should be 25 as well as PORT_MAX_8250.

Good catch, care to make up a patch to fix it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/