Re: [PATCH] drm/cirrus: Add bpp option

[Takashi Iwai]

At Tue, 29 Jan 2013 10:53:50 +0100,
Daniel Vetter wrote:
> 
> On Tue, Jan 29, 2013 at 09:29:17AM +0100, Takashi Iwai wrote:
> > Add a new option, bpp, to specify the default bpp value.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > 
> > This patch is applied on the top of previous two patches.
> > I couldn't find an easy way to specify the default bpp, so I cooked
> > the driver quickly.  If there is any other convenient way to achieve
> > this, let me know...
> 
> Well, you can specify the desired bpp with a full mode on the kernel
> cmdline - the '-bpp' extension. Reading through the parser I think it
> should work even with just the '-bpp' and not a full mode, but I haven't
> tested. Look for cmdline_mode->bpp_specified in drm_fb_helper.c and the
> relevant parsing code in drm_mode_parse_command_line_for_connector in
> drm_modes.c
> 
> If that doesn't work for you, I think it's better to extend/fix it than
> add driver module options.

Well, the fb can be set by that option, but the default modeset
doesn't seem to honor it.  So if you start X modeset driver, it still
takes what the driver sets as default.  That was the problem I hit.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/