Re: the patch "perf tools: Update Makefile for Android" broke 3.8-rc perf build.

From: Namhyung Kim
Date: Tue Jan 29 2013 - 02:00:13 EST


Hi Thomas,

On Tue, 29 Jan 2013 05:45:29 +0200, Thomas Backlund wrote:
> Linux Kernel Mailing List skrev 12.12.2012 05:13:
>> Gitweb: http://git.kernel.org/linus/;a=commit;h=d816ec2d1bea55cfeac373f0ab0ab8a3105e49b4
>> Commit: d816ec2d1bea55cfeac373f0ab0ab8a3105e49b4
>> Parent: 78da39faf7c903bb6e3c20a726fde1bf98d10af8
>> Author: Irina Tirdea <irina.tirdea@xxxxxxxxx>
>> AuthorDate: Mon Oct 8 09:43:27 2012 +0300
>> Committer: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>> CommitDate: Mon Oct 8 17:42:16 2012 -0300
>>
>> perf tools: Update Makefile for Android
>>
>> For cross-compiling on Android, some specific changes are needed in
>> the Makefile.
>>
>
> The above patch broke perf build on i586 and x86_64:
>
> [tmb@tmb linux-3.8-rc5]$ make -C tools/perf -s V=1
> HAVE_CPLUS_DEMANGLE=1 prefix=%{_prefix} all
> CHK -fstack-protector-all
> CHK -Wstack-protector
> CHK -Wvolatile-register-var
> CHK bionic
> <stdin>:1:31: fatal error: android/api-level.h: No such file or directory
> compilation terminated.

Are you sure does it break your build? In my case, it only hid the
compilation from user and kept the work behind us. When I run a clean
build I could see a final perf binary there.

It's because QUIET_{CC,LINK,...} honour the -s option but TRY_CC_MSG not
and maybe we need something like this: