Re: [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write

From: Minchan Kim
Date: Mon Jan 28 2013 - 18:21:32 EST


On Mon, Jan 28, 2013 at 09:16:35AM +0200, Pekka Enberg wrote:
> On Mon, Jan 28, 2013 at 2:38 AM, Minchan Kim <minchan@xxxxxxxxxx> wrote:
> > Now zram allocates new page with GFP_KERNEL in zram I/O path
> > if IO is partial. Unfortunately, It may cuase deadlock with
>
> s/cuase/cause/g

Thanks!

>
> > reclaim path so this patch solves the problem.
>
> It'd be nice to know about the problem in more detail. I'm also
> curious on why you decided on GFP_ATOMIC for the read path and
> GFP_NOIO in the write path.

In read path, we called kmap_atomic.

How about this?
------------------------- >8 -------------------------------