Re: [PATCH v2] userns: improve uid/gid map collision detection

[Aristeu Rozanski]

On Fri, Jan 25, 2013 at 06:31:37PM -0800, Eric W. Biederman wrote:
> Aritsteu after looking at both my version and yours I am going with

one extra t.

> mine.  While my code is a little wordier I have half the number of
> comparisons your code does, and I took the time to kill the variable
> introducing a function to test for range collisions makes unnecessary.
> On Andrews size metric my version seems noticably smaller as well.
> 
>  size $PWD-build/kernel/user_namespace.o
>    text	   data	    bss	    dec	    hex	filename
>    4376	    144	      0	   4520	   11a8	/home/eric/projects/linux/linux-userns-devel-build/kernel/user_namespace.o
> 
> 
> Short of something unexpected I plan to push all my code to linux-next
> sometime tomorrow.

sure, no problem
Thanks Eric

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/